actually fix the session score concurrency issue

fix rare bug with shared guid kicker plugin allow hiding of the connection lost notification
2025-06-10 15:20:48 -05:00 · 2020-04-22 18:46:41 -05:00
parent af441b5987
commit 0e6a7f89b2
10 changed files with 240 additions and 41 deletions
--- a/Tests/ApplicationTests/PluginTests.cs
+++ b/Tests/ApplicationTests/PluginTests.cs
@ -0,0 +1,86 @@
+using ApplicationTests.Fixtures;
+using ApplicationTests.Mocks;
+using FakeItEasy;
+using IW4MAdmin;
+using IW4MAdmin.Application.Misc;
+using Microsoft.Extensions.DependencyInjection;
+using NUnit.Framework;
+using SharedLibraryCore;
+using SharedLibraryCore.Database.Models;
+using SharedLibraryCore.Interfaces;
+using SharedLibraryCore.Services;
+using System;
+using System.Collections.Generic;
+using System.IO;
+using System.Linq;
+using System.Text;
+using System.Threading.Tasks;
+
+namespace ApplicationTests
+{
+    [TestFixture]
+    public class PluginTests
+    {
+        private static string PLUGIN_DIR = @"X:\IW4MAdmin\Plugins\ScriptPlugins";
+        private IServiceProvider serviceProvider;
+        private IManager fakeManager;
+        private MockEventHandler mockEventHandler;
+
+        [SetUp]
+        public void Setup()
+        {
+            serviceProvider = new ServiceCollection().BuildBase().BuildServiceProvider();
+            fakeManager = serviceProvider.GetRequiredService<IManager>();
+            mockEventHandler = new MockEventHandler();
+            A.CallTo(() => fakeManager.GetEventHandler())
+                .Returns(mockEventHandler);
+
+            var rconConnectionFactory = serviceProvider.GetRequiredService<IRConConnectionFactory>();
+
+            A.CallTo(() => rconConnectionFactory.CreateConnection(A<string>.Ignored, A<int>.Ignored, A<string>.Ignored))
+                 .Returns(serviceProvider.GetRequiredService<IRConConnection>());
+
+            A.CallTo(() => serviceProvider.GetRequiredService<IRConParser>().Configuration)
+                .Returns(ConfigurationGenerators.CreateRConParserConfiguration(serviceProvider.GetRequiredService<IParserRegexFactory>()));
+        }
+
+        [Test]
+        public async Task Test_GenericGuidClientIsKicked()
+        {
+            var plugin = new ScriptPlugin(Path.Join(PLUGIN_DIR, "SharedGUIDKick.js"), PLUGIN_DIR);
+            var server = serviceProvider.GetRequiredService<IW4MServer>();
+            server.GameName = Server.Game.IW4;
+            var client = ClientGenerators.CreateBasicClient(server, hasIp: false, clientState: EFClient.ClientState.Connecting);
+            client.NetworkId = -1168897558496584395;
+            var databaseClient = ClientGenerators.CreateDatabaseClient(hasIp: false);
+            databaseClient.NetworkId = client.NetworkId;
+
+            var fakeClientService = serviceProvider.GetRequiredService<ClientService>();
+            A.CallTo(() => fakeClientService.GetUnique(A<long>.Ignored))
+                .Returns(Task.FromResult(databaseClient));
+            A.CallTo(() => fakeManager.GetClientService())
+                .Returns(fakeClientService);
+
+            await plugin.Initialize(serviceProvider.GetRequiredService<IManager>());
+
+            var gameEvent = new GameEvent()
+            {
+                Origin = client,
+                Owner = server,
+                Type = GameEvent.EventType.PreConnect,
+                IsBlocking = true
+            };
+
+            await server.ExecuteEvent(gameEvent);
+
+            // connect
+            var e = mockEventHandler.Events[0];
+            await server.ExecuteEvent(e);
+            await plugin.OnEventAsync(e, server);
+
+            // kick
+            e = mockEventHandler.Events[1];
+            await server.ExecuteEvent(e);
+        }
+    }
+}