only unload plugins once at shutdown

clean up some doc warnings

SharedLibraryCore/Interfaces/IManager.cs

@@ -32,7 +32,7 @@ namespace SharedLibraryCore.Interfaces
         ConcurrentDictionary<long, GameEvent> ProcessingEvents { get; }
         Task Init();
         Task Start();
-        void Stop();
+        Task Stop();
         void Restart();
 
         [Obsolete]
@@ -103,4 +103,4 @@ namespace SharedLibraryCore.Interfaces
         /// </summary>
         event EventHandler<GameEvent> OnGameEventExecuted;
     }
-}
+}

SharedLibraryCore/Interfaces/IMetaService.cs

@@ -17,6 +17,7 @@ namespace SharedLibraryCore.Interfaces
         /// <param name="metaKey">key of meta data</param>
         /// <param name="metaValue">value of the meta data</param>
         /// <param name="client">client to save the meta for</param>
+        /// <param name="linkedMeta"></param>
         /// <returns></returns>
         Task AddPersistentMeta(string metaKey, string metaValue, EFClient client, EFMeta linkedMeta = null);
 

SharedLibraryCore/Interfaces/IMetaServiceV2.cs

@@ -42,7 +42,6 @@ public interface IMetaServiceV2
     /// <param name="lookupId">Id in the list of lookup values</param>
     /// <param name="clientId">id of the client</param>
     /// <param name="token"></param>
-    /// <typeparam name="T"></typeparam>
     /// <returns></returns>
     Task SetPersistentMetaForLookupKey(string metaKey, string lookupKey, int lookupId, int clientId,
         CancellationToken token = default);
@@ -100,7 +99,6 @@ public interface IMetaServiceV2
     /// <param name="lookupKey"></param>
     /// <param name="clientId"></param>
     /// <param name="token"></param>
-    /// <typeparam name="T"></typeparam>
     /// <returns></returns>
     Task<EFMeta> GetPersistentMetaByLookup(string metaKey, string lookupKey, int clientId,
         CancellationToken token = default);
@@ -141,7 +139,6 @@ public interface IMetaServiceV2
     /// removes meta key with given value
     /// </summary>
     /// <param name="metaKey">key of the meta data</param>
-    /// <param name="metaValue">value of the meta data</param>
     /// <param name="token"></param>
     /// <returns></returns>
     Task RemovePersistentMeta(string metaKey, CancellationToken token = default);

SharedLibraryCore/Interfaces/IRConConnection.cs

@@ -14,6 +14,7 @@ namespace SharedLibraryCore.Interfaces
         /// </summary>
         /// <param name="type">type of RCon query to perform</param>
         /// <param name="parameters">optional parameter list</param>
+        /// <param name="token"></param>
         /// <returns></returns>
         Task<string[]> SendQueryAsync(StaticHelpers.QueryType type, string parameters = "", CancellationToken token = default);
 

SharedLibraryCore/Interfaces/IRConParser.cs

@@ -52,6 +52,7 @@ namespace SharedLibraryCore.Interfaces
         /// <param name="connection">RCon connection to retrieve with</param>
         /// <param name="dvarName">name of DVAR</param>
         /// <param name="fallbackValue">default value to return if dvar retrieval fails</param>
+        /// <param name="token"></param>
         /// <returns></returns>
         Task<Dvar<T>> GetDvarAsync<T>(IRConConnection connection, string dvarName, T fallbackValue = default, CancellationToken token = default);
 
@@ -61,6 +62,7 @@ namespace SharedLibraryCore.Interfaces
         /// <param name="connection">RCon connection to use</param>
         /// <param name="dvarName">name of DVAR to set</param>
         /// <param name="dvarValue">value to set DVAR to</param>
+        /// <param name="token"></param>
         /// <returns></returns>
         Task<bool> SetDvarAsync(IRConConnection connection, string dvarName, object dvarValue, CancellationToken token = default);
 
@@ -69,13 +71,15 @@ namespace SharedLibraryCore.Interfaces
         /// </summary>
         /// <param name="connection">RCon connection to use</param>
         /// <param name="command">console command to execute</param>
+        /// <param name="token"></param>
         /// <returns></returns>
         Task<string[]> ExecuteCommandAsync(IRConConnection connection, string command, CancellationToken token = default);
-        
+
         /// <summary>
         ///     get the list of connected clients from status response
         /// </summary>
         /// <param name="connection">RCon connection to use</param>
+        /// <param name="token"></param>
         /// <returns>
         ///     <see cref="IStatusResponse" />
         /// </returns>

SharedLibraryCore/Interfaces/IScriptPluginServiceResolver.cs

@@ -16,8 +16,8 @@
         ///     resolves a service with the given name and generic params
         /// </summary>
         /// <param name="serviceName">class name of service</param>
-        /// <param name="genericParams">generic class names</param>
+        /// <param name="genericParameters">generic class names</param>
         /// <returns></returns>
         object ResolveService(string serviceName, string[] genericParameters);
     }
-}
+}

SharedLibraryCore/Interfaces/ITokenAuthentication.cs

@@ -14,8 +14,9 @@ namespace SharedLibraryCore.Interfaces
         /// <summary>
         ///     authorizes given token
         /// </summary>
+        /// <param name="networkId">network id of the client to authorize</param>
         /// <param name="token">token to authorize</param>
         /// <returns>true if token authorized successfully, false otherwise</returns>
         bool AuthorizeToken(long networkId, string token);
     }
-}
+}