INSANEMODE/IW4M-Admin
1
0
Fork 0
mirror of https://github.com/RaidMax/IW4M-Admin.git synced 2025-06-11 07:40:54 -05:00
Code Issues Releases Wiki Activity

Refactor Login plugin and clean up code

Browse Source 
The Login plugin code has been optimized and cleaned up. This refactoring includes removing unnecessary conditions, switching to a more readable syntax, and deleting deprecated methods or properties. The possibility of a null configuration is also eliminated to improve code reliability.
This commit is contained in:
Ayymoss
2024-07-16 23:58:18 +01:00
parent c4defacabc
commit 279016c405
5 changed files with 24 additions and 40 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
Plugins/Login/Plugin.cs
View File

@ -16,13 +16,13 @@ public class Plugin : IPluginV2
public string Name => "Login";
public string Version => Utilities.GetVersionAsString();
public string Author => "RaidMax";
private readonly LoginStates _loginStates;
public Plugin(LoginConfiguration configuration, LoginStates loginStates)
{
_loginStates = loginStates;
if (!(configuration?.RequirePrivilegedClientLogin ?? false))
if (!configuration.RequirePrivilegedClientLogin)
{
return;
}
@ -38,7 +38,7 @@ public class Plugin : IPluginV2
public static void RegisterDependencies(IServiceCollection serviceCollection)
{
serviceCollection.AddConfiguration<LoginConfiguration>("LoginPluginSettings");
serviceCollection.AddConfiguration("LoginPluginSettings", new LoginConfiguration());
serviceCollection.AddSingleton(new LoginStates());
}
@ -64,20 +64,12 @@ public class Plugin : IPluginV2
return true;
}
if (gameEvent.Extra.GetType() == typeof(SetPasswordCommand) &&
gameEvent.Origin?.Password == null)
switch (gameEvent.Extra)
{
return true;
}
if (gameEvent.Extra.GetType() == typeof(LoginCommand))
{
return true;
}
if (gameEvent.Extra.GetType() == typeof(RequestTokenCommand))
{
return true;
case SetPasswordCommand when gameEvent.Origin?.Password is null:
case LoginCommand:
case RequestTokenCommand:
return true;
}
if (!_loginStates.AuthorizedClients[gameEvent.Origin.ClientId])