Address some review comments

This commit is contained in:
GPUCode
2023-11-19 11:21:53 +02:00
committed by t895
parent 8fab363237
commit 6de2edcca1
12 changed files with 30 additions and 35 deletions

View File

@ -409,11 +409,14 @@ static void* ChooseVirtualBase(size_t virtual_size) {
return MAP_FAILED;
}
#else
static void* ChooseVirtualBase(size_t virtual_size) {
return mmap(nullptr, virtual_size, PROT_READ | PROT_WRITE,
MAP_PRIVATE | MAP_ANONYMOUS | MAP_NORESERVE, -1, 0);
}
#endif
class HostMemory::Impl {

View File

@ -181,7 +181,7 @@ struct Values {
// Cpu
SwitchableSetting<CpuBackend, true> cpu_backend{
linkage, CpuBackend::Nce, CpuBackend::Dynarmic,
linkage, CpuBackend::Dynarmic, CpuBackend::Dynarmic,
#ifdef ARCHITECTURE_arm64
CpuBackend::Nce,
#else

View File

@ -10,8 +10,8 @@
namespace Common {
// Android's ART overrides sigaction with its own wrapper. This is problematic for SIGSEGV
// in particular, because ARTs handler access TPIDR_EL0, so this extracts the libc version
// and calls it directly.
// in particular, because ART's handler accesses tpidr_el0, which conflicts with NCE.
// This extracts the libc symbol and calls it directly.
int SigAction(int signum, const struct sigaction* act, struct sigaction* oldact);
} // namespace Common