INSANEMODE/yuzu-android
1
0
Fork 0
mirror of https://github.com/yuzu-emu/yuzu-android.git synced 2025-06-22 16:58:28 -05:00
Code Issues Packages Projects Releases Wiki Activity

fsp_srv: Use std::string_view's copy() function instead of strncpy()

Browse Source 
Given elements inserted into a vector are zeroed out, we can just copy
MAX_LEN - 1 elements and the data will already be properly null
terminated.
This commit is contained in:
Lioncash
2018-08-08 17:49:57 -04:00
parent 4afb05d0cc
commit 7353cfc781
2 changed files with 10 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/core/hle/service/filesystem/fsp_srv.cpp
View File

@ -196,11 +196,7 @@ static void BuildEntryIndex(std::vector<FileSys::Entry>& entries, const std::vec
entries.reserve(entries.size() + new_data.size());
for (const auto& new_entry : new_data) {
auto& entry = entries.emplace_back();
entry.filename[0] = '\0';
std::strncat(entry.filename, new_entry->GetName().c_str(), FileSys::FILENAME_LENGTH - 1);
entry.type = type;
entry.file_size = new_entry->GetSize();
entries.emplace_back(new_entry->GetName(), type, new_entry->GetSize());
}
}