INSANEMODE/yuzu-android
1
0
Fork 0
mirror of https://github.com/yuzu-emu/yuzu-android.git synced 2025-06-10 20:48:10 -05:00
Code Issues Packages Projects Releases Wiki Activity

partition_filesystem: Ensure all class members of PartitionFilesystem are initialized

Browse Source 
Previously is_hfs and pfs_header members wouldn't be initialized in the
constructor, as they were stored in locals instead. This would result in
things like GetName() and PrintDebugInfo() behaving incorrectly.

While we're at it, initialize the members to deterministic values as
well, in case loading ever fails.
This commit is contained in:
Lioncash
2018-07-18 23:25:07 -04:00
parent 1371e2fb6a
commit 9abc5763b6
2 changed files with 15 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/core/file_sys/partition_filesystem.h
View File

@ -42,6 +42,8 @@ private:
u32_le num_entries;
u32_le strtab_size;
INSERT_PADDING_BYTES(0x4);
bool HasValidMagicValue() const;
};
static_assert(sizeof(Header) == 0x10, "PFS/HFS header structure size is wrong");
@ -73,11 +75,11 @@ private:
#pragma pack(pop)
Loader::ResultStatus status;
Loader::ResultStatus status{};
Header pfs_header;
bool is_hfs;
size_t content_offset;
Header pfs_header{};
bool is_hfs = false;
size_t content_offset = 0;
std::vector<VirtualFile> pfs_files;
std::vector<VirtualDir> pfs_dirs;