Address a bunch of review comments

This commit is contained in:
fearlessTobi
2018-09-17 17:16:01 +02:00
parent 4d139943f2
commit b4ace6ec6f
11 changed files with 27 additions and 19 deletions

View File

@ -27,7 +27,11 @@ CompatDB::CompatDB(QWidget* parent)
CompatDB::~CompatDB() = default;
enum class CompatDBPage { Intro = 0, Selection = 1, Final = 2 };
enum class CompatDBPage {
Intro = 0,
Selection = 1,
Final = 2,
};
void CompatDB::Submit() {
QButtonGroup* compatibility = new QButtonGroup(this);

View File

@ -21,7 +21,6 @@ public:
private:
std::unique_ptr<Ui::CompatDB> ui;
private slots:
void Submit();
void EnableNext();
};

View File

@ -25,7 +25,7 @@ ConfigureWeb::ConfigureWeb(QWidget* parent)
this->setConfiguration();
}
ConfigureWeb::~ConfigureWeb() {}
ConfigureWeb::~ConfigureWeb() = default;
void ConfigureWeb::setConfiguration() {
ui->web_credentials_disclaimer->setWordWrap(true);

View File

@ -11,7 +11,7 @@ namespace DiscordRPC {
class DiscordImpl : public DiscordInterface {
public:
DiscordImpl();
~DiscordImpl();
~DiscordImpl() override;
void Pause() override;
void Update() override;

View File

@ -115,7 +115,7 @@ void GMainWindow::ShowTelemetryCallout() {
}
UISettings::values.callout_flags |= static_cast<uint32_t>(CalloutFlag::Telemetry);
static const QString telemetry_message =
const QString telemetry_message =
tr("<a href='https://citra-emu.org/entry/telemetry-and-why-thats-a-good-thing/'>Anonymous "
"data is collected</a> to help improve yuzu. "
"<br/><br/>Would you like to share your usage data with us?");