INSANEMODE/yuzu-android
1
0
Fork 0
mirror of https://github.com/yuzu-emu/yuzu-android.git synced 2025-06-14 01:38:20 -05:00
Code Issues Packages Projects Releases Wiki Activity

gdbstub: Remove global variable from public interface

Browse Source 
Currently, this is only ever queried, so adding a function to check if the
server is enabled is more sensible.

If directly modifying this externally is ever desirable, it should be done
by adding a function to the interface, rather than exposing implementation
details directly.
This commit is contained in:
Lioncash
2016-12-15 16:19:30 -05:00
parent 3e4cc6b3d2
commit ba20dd9b61
5 changed files with 23 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/core/gdbstub/gdbstub.h
View File

@ -5,7 +5,7 @@
// Originally written by Sven Peter <sven@fail0verflow.com> for anergistic.
#pragma once
#include <atomic>
#include "common/common_types.h"
namespace GDBStub {
@ -24,10 +24,6 @@ struct BreakpointAddress {
BreakpointType type;
};
/// If set to false, the server will never be started and no gdbstub-related functions will be
/// executed.
extern std::atomic<bool> g_server_enabled;
/**
* Set the port the gdbstub should use to listen for connections.
*
@ -36,7 +32,7 @@ extern std::atomic<bool> g_server_enabled;
void SetServerPort(u16 port);
/**
* Set the g_server_enabled flag and start or stop the server if possible.
* Starts or stops the server if possible.
*
* @param status Set the server to enabled or disabled.
*/
@ -48,6 +44,9 @@ void Init();
/// Stop gdbstub server.
void Shutdown();
/// Checks if the gdbstub server is enabled.
bool IsServerEnabled();
/// Returns true if there is an active socket connection.
bool IsConnected();